-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status change on user action #73
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Mustafa Jafar <mustafataherzaky@outlook.com>
I have doubts about code style and some decisions i've made to make it work, bot it works now help me please to make code and logic pretty please) Hope you like it! |
could you create an issue for your enhancement request/suggestion and link it to this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test run the PR yet.
I'd recommend adding settings in multiple places. so that we have them near to each other so that we know that these settings belongs to the same feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timsergeeff could you please install a linter for your IDE that matches the code style of the repo, mostly PEP08. There's a lot of invalid blank lines.
Also, a spell-checker may also help since the log messages contain typos.
Co-authored-by: Mustafa Jafar <mustafataherzaky@outlook.com>
Co-authored-by: Mustafa Jafar <mustafataherzaky@outlook.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Mustafa Jafar <mustafataherzaky@outlook.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Mustafa Jafar <mustafataherzaky@outlook.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filename has a typo cahnge
-> change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh sorry will fix
i dont undestand how to remove this |
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
if not project_settings["set_pause_status_to_other_tasks"]: | ||
self.log.info(f"Pausing all other tasks with same status disabled.") | ||
else: | ||
self.log.info(f"Pausing all other tasks with same status enabled.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't understand this use case - why would launching a task pause all other tasks? :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a ton of situations when artist started a task and then switched to another and mark it wip resulting in two WIP tasks at the same time and it makes tracking of production confusing and harder to make nessesary desigions fast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a ton of situations when artist started a task and then switched to another and mark it wip resulting in two WIP tasks at the same time and it makes tracking of production confusing and harder to make nessesary desigions fast
It's interesting - because on our studio for example it's quite common for someone to do that (usually working on a few smaller tasks at once) and they'd basically open both and sometimes do a bit in one, then some stuff in the other almost simultaneously. For smaller tasks though where usually waiting needs to happen in-between (e.g. test-rendering, etc. and then continuing with something else while the test render is occurring in the background). Both tasks being active then is the logical state.
Anyway... will leave the "production scenarios" reviewing of this to others. @dee-ynput
Also, something tells me we should be setting this statuses TO AYON - and then sync to all the others or whatever so we don't need to duplicate this logic for kitsu, shotgrid, ftrack, etc. but have on entry point in the code to do this - no matter the production tracker integration. But maybe I'm too hopeful.
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@MustafaJafar i think i cant connect pr with issue because of rules of repo |
App start status change
Now we have ability to change status on users starting app action.
Pause other tasks with WIP status
We can turn off pausing all other WIP tasks. This logic made of state: only one task can be WIP at a time.
Farm render status change
Previosly task was getting status change (WFA) only at publishing state in deadline so in between of publishing job to farm and publishing to kitsu we have nothing indicating current task status. Now we have FARM status change when farm rendering is on
Additional info
The settings allow to configure status change conditions so statuses will not double. And some other changes to settings needed to be done to make all logic work and ahve opportunity to swith in on or off
Testing notes: