Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Allow superproject to provide dependencies with add_subdirectory() #14

Merged
merged 2 commits into from
Mar 17, 2024
Merged

🔧 Allow superproject to provide dependencies with add_subdirectory() #14

merged 2 commits into from
Mar 17, 2024

Conversation

thirtythreeforty
Copy link
Contributor

@thirtythreeforty thirtythreeforty commented Mar 14, 2024

This lets a superproject vendor cpp-yyjson along with these dependencies, doing something like:

add_subdirectory(yyjson)
add_subdirectory(fmt)
add_subdirectory(nameof)
add_subdirectory(cpp-yyjson)

and cpp-yyjson will use the dependencies provided by the parent Cmake project, without trying to find them installed.

@yosh-matsuda yosh-matsuda merged commit 0bc1494 into yosh-matsuda:main Mar 17, 2024
9 checks passed
@yosh-matsuda
Copy link
Owner

Merged, thanks!

@thirtythreeforty
Copy link
Contributor Author

Thanks! And thanks for the second pass, I overlooked the versioning checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants