-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New colors for DNA #296
Comments
Just a note. We can't just remove the current colors. We can add new colors to DNA and all DNA components but there are custom code across Nuuday that has dependencies to our bcurrent colors. The solution is to add a new |
OK. I understand that. The new colors to be added are: the Secondary colors and the Label colors. |
Can you rename colors? |
@grandorf I think it would be better to update the existing page with the new colors, and rename the old page to "Old colors (deprecated)" page to make it absolutely clear which set of colors to use going forward :) In terms of variable names, I'm not sure how to proceed without introducing something like The other option is to only make one breaking update, where all old colors are renamed to e.g. $ys-color-error-red-deprecated. As a developer you could then either update to the new colors where available and fall back to the old colors where needed. Or you could replace all variable names with the deprecated ones and not make a single visible change - for now. |
@havgry I'm not a fan of renaming existing colors with the word deprecated as suffix. The reason is if we force everybody to make changes anyway then we should use the opportunity to let them use the new colors and not help them in getting in to technical debt. |
There will be the same amount of technical debt (if you choose not to update everything in one go) with either approach - you'll be using outdated colors whichever way you name it. For me, it's more important to choose good names that work going forward. What's your suggestion in terms of new variable names for let's say the error color? With the |
You decide if we change the names or not. :-) |
We have made some color changes for yousee.dk
In this figma link you can see the old colors and the new.
https://www.figma.com/file/21BhM7ixlKsfwr2RUUHKdL/Design-System-Web?node-id=2%3A8304
All the names and color code is there.
If anything is needed please contact me
The text was updated successfully, but these errors were encountered: