ybase: add regularVsNonRegular or similar #9534
Labels
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Jira Link: DB-2165
We have macros and functions that switch between two given values depending on whether the build type is sanitizer or nonsanitizer. This is mostly used for timing in tests because sanitizer builds tend to take longer.
Commit 80b8598, titled "[#6643] Disable optimizations for debug build", changes the debug build type so that it disables compiler optimizations, going from
-O1
to nothing. It is noticeable how much slower operations are with that change. I estimate that timing at least doubled. SELECTs to an empty table take ~10ms instead of ~5ms; CREATE INDEX (concurrently) takes ~10s instead of ~3s.This affects the amount of time tests take, so existing tests can more easily hit timeout. One of my in-progress Java tests
TestPgRegressGin
hits 500s timeout consistently (on debug build) after rebasing over this commit. After bumping up the timeout, it appears that the test takes 712.844s. This is very similar to ASAN, which takes 891.754s.The point is that debug probably belongs in the sanitizers category of timing. release and fastdebug take about half as long as debug, asan, and tsan. Therefore, new switch functions should be created for this arrangement (or the existing ones should update the arrangement (and probably rename themselves accordingly)).
keywords: SanitizerUtil.nonSanitizerVsSanitizer, SanitizerUtil, nonSanitizerVsSanitizer, RegularBuildVsSanitizers, IsSanitizer, NonTsanVsTsan
The text was updated successfully, but these errors were encountered: