From 32fa90c9bac0355680c19f2f76d78aa9af2a4ba0 Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Wed, 25 Mar 2020 14:33:31 +0100 Subject: [PATCH] Fix ClusterHealthIT.testHealthOnMasterFailover (#54170) (#54177) We can run into a state where there's no more events to wait for temporarily but the cluster still isn't green. I added the wait for green flag to the request so the assertion for green cluster health below doesn't fail. Closes #53457 --- .../test/java/org/elasticsearch/cluster/ClusterHealthIT.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/src/test/java/org/elasticsearch/cluster/ClusterHealthIT.java b/server/src/test/java/org/elasticsearch/cluster/ClusterHealthIT.java index 1d264a31fbdb3..63cb6a45e1a72 100644 --- a/server/src/test/java/org/elasticsearch/cluster/ClusterHealthIT.java +++ b/server/src/test/java/org/elasticsearch/cluster/ClusterHealthIT.java @@ -303,7 +303,8 @@ public void testHealthOnMasterFailover() throws Exception { // Run a few health requests concurrent to master fail-overs against a data-node to make sure master failover is handled // without exceptions for (int i = 0; i < 20; ++i) { - responseFutures.add(client(node).admin().cluster().prepareHealth().setWaitForEvents(Priority.LANGUID).execute()); + responseFutures.add(client(node).admin().cluster().prepareHealth().setWaitForEvents(Priority.LANGUID) + .setWaitForGreenStatus().execute()); internalCluster().restartNode(internalCluster().getMasterName(), InternalTestCluster.EMPTY_CALLBACK); } for (ActionFuture responseFuture : responseFutures) {