Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Need a hand? #119

Open
mehcode opened this issue Sep 19, 2017 · 8 comments
Open

Need a hand? #119

mehcode opened this issue Sep 19, 2017 · 8 comments

Comments

@mehcode
Copy link

mehcode commented Sep 19, 2017

@zargony

I'm working on ide-rust in conjunction with the Atom IDE and Rust Dev Tools movements.

I have some pain points with language-rust and I was taking a look but it seems like at least one of them ( #82 ) has an open PR.

I'd love to help you with adding syntax and improvements to the grammar here. Thoughts?

@zargony
Copy link
Owner

zargony commented Sep 20, 2017

Any help would be much appreciated. Unfortunately I currently don't find much time to spend on improving language-rust. Most open issues are "complicated", i.e. they're not simple grammar rules problems but need a deeper look into how atom packages work (which I unfortunately don't have). If you'd like to stay for a while and help to move things ahead, I could as well add you as a collaborator. We should just make sure to discuss bigger changes openly first and to have working specs all time to prevent regressions.

#82 looks nice, but is missing some automated specs. It adds some lines to test.rs which was used for manually reviewing syntax highlighting before we had specs.

@jens1o
Copy link

jens1o commented Aug 8, 2018

Any help would be much appreciated. Unfortunately I currently don't find much time to spend on improving language-rust. Most open issues are "complicated", i.e. they're not simple grammar rules problems but need a deeper look into how atom packages work (which I unfortunately don't have).

Is this still the case @zargony ?

@zargony
Copy link
Owner

zargony commented Aug 8, 2018

Yes. I think I know Rust pretty well, but my knowledge of Atom’s JS internals is limited and RL keeps me busy, so I appreciate any help.

@mehcode
Copy link
Author

mehcode commented Aug 8, 2018

ide-rust directly depends on this and @alexheretic now (and for quite some time) maintains it so he might have time and interest to help here

@jens1o
Copy link

jens1o commented Aug 9, 2018

That would be great, to further improve this project! :)

@alexheretic
Copy link

alexheretic commented Aug 15, 2018

Yes I, and all atom rust users, am interested in improvements (though overall it's still working pretty well). However, I don't have a lot of free time myself at the moment.

Interestingly it looks like they'll also be official rust support for atom when they adopt the tree-sitter parsing system: https://github.com/atom/language-rust. But who knows when that'll be.

@alexheretic
Copy link

fyi atom/atom#18257

@zargony
Copy link
Owner

zargony commented Oct 18, 2018

Thanks. Looks like there’s a tree-sitter based grammar for Rust now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants