Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI jobs on Windows are failing #173

Closed
ludovicm67 opened this issue Apr 16, 2024 · 4 comments · Fixed by #176
Closed

CI jobs on Windows are failing #173

ludovicm67 opened this issue Apr 16, 2024 · 4 comments · Fixed by #176
Assignees
Labels
bug Something isn't working

Comments

@ludovicm67
Copy link
Member

By looking at the CI jobs, it seems that all jobs that are run on Windows are always failing for now during the installation of the dependencies step, like here: https://github.com/zazuko/cube-link/actions/runs/8702440720/job/23866486071.

@ludovicm67 ludovicm67 added the bug Something isn't working label Apr 16, 2024
@ludovicm67
Copy link
Member Author

I was able to find the cause: approvals/Approvals.NodeJS#176

We need to wait for a fix.

@tpluscode
Copy link
Contributor

Might also pin to a past version?

@ludovicm67
Copy link
Member Author

The pin should only be a temporary solution the time a fix is provided.
So once the fix is available, we should roll back the custom change.

@maxwelliverson
Copy link

This is specifically caused by the a recent security patch to node, whereby spawn now rejects batch files. Instead, the script should be spawned in a new shell, and this can be done simply by using { shell: true }, as indicated by nodejs/node#52554 (comment)

This seemed to be the expected fix going forward; given that the issue was caused by patching a security vulnerability, it won't be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants