-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchBox enhancements #523
Comments
On my iOS device it works, but only with a double click. |
How about also adding types to the options? |
@Dlurak – yes, please! There is a TODO in code already, though we would need to completely refactor the types. Typescript can't discriminate among the different options based on our current shape. It need explicit type field with enum
I will review your #552 today, and then you can add the types. If you decided to do that, please, create one PR only for the refactoring, and second PR (based on first) with the additional types with adding new functionality. Otherwise the code review is a headache 😃 //edit @Dlurak - wow, I am reviewing the #552 and I am very pleasantly surprised! You already added the |
Few ideas - each one should be one PR
Fixes:
building p
should offerBuilding Part
on the first placeExplorations
op:nwr
, it can freeze their browser.Features
/?q=op:node["shop"]
#119coordinates
– parse all coordinate typesosmId
– parse shortId, apiId or URL with some of these ids.Completed
Bexhill-on-Sea
- it can't be clicked (SearchBox: Fix broken flyTo on mobile #574)The text was updated successfully, but these errors were encountered: