Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace allowRevealedAmounts boolean argument to z_sendmany with a strategy string argument #5676

Closed
str4d opened this issue Mar 15, 2022 · 1 comment
Closed

Replace allowRevealedAmounts boolean argument to z_sendmany with a strategy string argument #5676

str4d opened this issue Mar 15, 2022 · 1 comment
Labels
A-rpc-interface Area: RPC interface A-wallet Area: Wallet S-committed Status: Planned work in a sprint
Milestone
Release 4.7.0

Comments

@str4d
Copy link
Contributor

str4d commented Mar 15, 2022

To close this issue, the strategy flag needs to accept the string allowRevealedAmounts and interpret it the same way as the existing boolean flag. We can make this change because the allowRevealedAmounts flag has not yet been deployed in a release.

See discussion here for motivation: https://github.com/zcash/zcash/pull/5665/files/84cd3e54d82642e2aadad02166ab14f8ec695da6#r826335592
@str4d str4d added A-wallet Area: Wallet A-rpc-interface Area: RPC interface labels Mar 15, 2022
@nuttycom nuttycom added this to the Core Sprint 2022-10 milestone Mar 15, 2022
@nuttycom nuttycom added the S-committed Status: Planned work in a sprint label Mar 15, 2022
@str4d str4d mentioned this issue Mar 15, 2022
Merged
str4d added a commit to str4d/zcash that referenced this issue Mar 18, 2022
@str4d
z_sendmany: Replace allowRevealedAmount with privacyStrategy
1505121 
This replaces the bool argument with a string argument, enabling us to
add additional privacy strategies. We also alter the default to be
backwards-compatible with existing RPC method usage, by only enabling
the strongest checks if a Unified Address is involved.

Closes zcash#5676.
@nuttycom
Copy link
Contributor

Fixed by #5693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc-interface Area: RPC interface A-wallet Area: Wallet S-committed Status: Planned work in a sprint
Projects
None yet
Milestone
Release 4.7.0
Development

No branches or pull requests
2 participants
@nuttycom @str4d