Terminal: Go to Recent Directory

[tannal]

Check for existing issues

• Completed

Describe the feature

Vscode have a stack which store all the directories user changed.
It is very useful for navigating working directory in the terminal.

If applicable, add mockups / screenshots to help present your vision of the feature

Ctrl+g

[tannal]

Well, I do want to implement this feature for zed but don't know where to start with.

[notpeter]

Gotcha, in VSCode "Terminal: Go to Recent Directory" is bound to cmd-g (Mac). For reference, what's the Linux shortcut?

I haven't used the feature, does it just suggest recent folders from your project or does pull out recent directories you've manually entered via typing cd whatever in terminal too?

[tannal]

It's ctrl-g on Linux and Windows.

does pull out recent directories you've manually entered via typing cd whatever in terminal too?

Yes.

[notpeter]

does pull out recent directories you've manually entered via typing cd whatever in terminal too?

yes

Interesting. I think Zed would have to monitor the shell subprocess to keep track of this. On Linux this could leverage inotify on /proc/<pid>/cwd but on MacOS I think Zed would have to periodically poll for this info from the child process with proc_pidinfo.

[SomeoneToIgnore]

Zed already does

zed/crates/terminal/src/terminal.rs

Line 682 in 4441150

if self.pty_info.has_changed() {

where AlacTermEvent::Wakeup is an event appearing on new terminal content.

cwd is retrieved via

zed/crates/terminal/src/terminal.rs

Lines 710 to 712 in 4441150

	pub fn get_cwd(&self) -> Option<PathBuf> {
	self.pty_info.current.as_ref().map(|info| info.cwd.clone())
	}

so all that's needed is to store and update this info somehow.
Similarly, we can reuse this to restore terminals with their current paths.