Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: deprecate z_arch_esf_t with struct arch_esf, introduce an arch-agnostic exception.h for it #73593

Merged
merged 9 commits into from
Jun 4, 2024
Merged

arch: deprecate z_arch_esf_t with struct arch_esf, introduce an arch-agnostic exception.h for it #73593

merged 9 commits into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. arch: Create include/zephyr/arch/exception.h 

    Create `zephyr/include/zephyr/arch/exception.h`, which will
redirect to the corrent architecture-specific exception header
based on Kconfig.

Some of the architectures define their esf struct in
architecture-specific `arch.h`, refactor them out into a
separate `exception.h`.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    036b161 View commit details
    Browse the repository at this point in the history

  2. include: include exception.h in fatal.h 

    `fatal.h` has 2 functions that use the `z_arch_esf_t` type.

Include `exception.h`, which should have the `z_arch_esf_t`
defined.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7eb27ab View commit details
    Browse the repository at this point in the history

  3. arch: rename all esf struct to struct arch_esf 

    Rename every architecture's esf struct to `struct esf`.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0e4ab72 View commit details
    Browse the repository at this point in the history

  4. arch: define struct arch_esf and deprecate z_arch_esf_t 

    Make `struct arch_esf` compulsory for all architectures by
declaring it in the `arch_interface.h` header.

After this commit, the named struct `z_arch_esf_t` is only used
internally to generate offsets, and is slated to be removed
from the `arch_interface.h` header in the future.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0761307 View commit details
    Browse the repository at this point in the history

  5. arch: remove the use of z_arch_esf_t completely from internal 

    Created `GEN_OFFSET_STRUCT` & `GEN_NAMED_OFFSET_STRUCT` that
works for `struct`, and remove the use of `z_arch_esf_t`
completely.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1f41a98 View commit details
    Browse the repository at this point in the history

  6. doc: releases: update migration guide for the struct arch_esf 

    Add a note about the introduction of `struct arch_esf` and the
deprecation of `z_arch_esf_t`.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7989211 View commit details
    Browse the repository at this point in the history

  7. manifest: update sof git revision 

    Update the git revision of the `sof` module.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    123924e View commit details
    Browse the repository at this point in the history

  8. include: optimize the order of includes for x86 

    x86 32bit defines `CONFIG_X86` while its 64bit counterpart
defines an additional `CONFIG_X86_64`, by reordering the
include order we can make it look a bit cleaner.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    47ca0bb View commit details
    Browse the repository at this point in the history

  9. include: stop breaking the compilation of OOT architectures 

    Zephyr support out-of-tree architectures so we shouldn't
throw error for archs not listed here.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
    @ycsin
    ycsin committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0382366 View commit details
    Browse the repository at this point in the history