Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UPP loading redundancy #2382

Open
srallen opened this issue Aug 23, 2021 · 1 comment
Open

Remove UPP loading redundancy #2382

srallen opened this issue Aug 23, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@srallen
Copy link
Contributor

srallen commented Aug 23, 2021

Package app-project and lib-classifier

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The UPP is loaded and stored in both the project app and classifier library. This is redundant. The classifier only needs to know about the UPP to know if the tutorial has been seen before and to store those last seen dates.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Proposed solution is that the project app just be responsible for the UPP since it is used for more features there. The classifier can take in two props: one for the tutorial last seen dates as well as a callback for updating the UPP if needed.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Another option would be to pass in a snapshot for the UPP and continue to have a copy of it in the classifier store. The UPP store can be refactored to only make a request for it if a snapshot isn't passed in to the classifier.

Additional context

Add any other context or screenshots about the feature request here.

@srallen srallen added the enhancement New feature or request label Aug 23, 2021
@srallen
Copy link
Contributor Author

srallen commented Aug 25, 2021

Removing the UPP from the classifier will also mean that the UPP store in the project app will have to be updated to manage creating the UPP resource upon first visit of the classify page. Perhaps the callback for updating the last seen timestamp of the tutorial can manage this too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant