Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overrides.CredentialManager:false inconsistencies #1469

Open
Tracked by #1671
phaumer opened this issue Jul 11, 2022 · 2 comments
Open
Tracked by #1671

Fix overrides.CredentialManager:false inconsistencies #1469

phaumer opened this issue Jul 11, 2022 · 2 comments
Labels
bug Something isn't working community-upvoted enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits

Comments

@phaumer
Copy link
Member

phaumer commented Jul 11, 2022

When creating a ~/.zowe/settings/imperative.json file with {"overrides": {"CredentialManager": false}} I can disable secure credentials, which is important for platforms that do not support keytar such as Eclipse Che.

However, that setting is not used systematically and can lead to a lot of user confusion and even incorrect error messages:

  • With this file in place and running a zowe config init command it still generates a config file that has secure credentials defined. It should generate a template file without any secure fields.
  • When running commands with such secure credentials in the config file one gets errors about not being able to load keytar, which it should not attempt anymore as it was disabled. Instead it should show a warning that secure credentials are disabled and continue the operation by prompting the end user for the missing property values.

As creating such a ~/.zowe/settings/imperative.json file is a bit of a hidden feature I would also propose to

  • provide a config init command with a --non-secure option that will generate the settings file as well as create a correct non secure config file
  • provide a config init command that allows specifying the name of a custom config file to use instead of the template to support automation, e.g. during Eclipse workspace startup, that can generate these file from a client (such as Zowe Explorer)
@ATorrise ATorrise added bug Something isn't working enhancement New feature or request for-review To be reviewed in an Eng & Prod Mgmt meeting labels Sep 1, 2022
@zFernand0 zFernand0 added priority-medium Not functioning - next quarter if capacity permits for-review-pm and removed for-review To be reviewed in an Eng & Prod Mgmt meeting labels Oct 7, 2022
@zFernand0 zFernand0 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working enhancement New feature or request labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community-upvoted enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits
Projects
Status: Medium Priority
Development

No branches or pull requests

4 participants