Skip to content

Commit

Permalink
hfs-hfsplus-follow-macos-time-behavior-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: space prohibited after that '-' (ctx:WxW)
torvalds#87: FILE: fs/hfs/hfs_fs.h:265:
+	ut -= - sys_tz.tz_minuteswest * 60;
 	      ^

WARNING: line over 80 characters
torvalds#100: FILE: fs/hfs/hfs_fs.h:276:
+#define hfs_m_to_utime(time)   (struct timespec){ .tv_sec = __hfs_m_to_utime(time) }

total: 1 errors, 1 warnings, 71 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/hfs-hfsplus-follow-macos-time-behavior.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
  • Loading branch information
akpm00 authored and sfrothwell committed Jul 22, 2018
1 parent 4809160 commit 10d1bc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/hfs/hfs_fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ static inline time64_t __hfs_m_to_utime(__be32 mt)

static inline __be32 __hfs_u_to_mtime(time64_t ut)
{
ut -= - sys_tz.tz_minuteswest * 60;
ut -= -sys_tz.tz_minuteswest * 60;

/*
* MacOS wraps "invalid" times after 2040 when writing back, so
Expand Down

0 comments on commit 10d1bc3

Please sign in to comment.