Skip to content

Commit

Permalink
staging: rtl8723bs: remove typedefs in hal_com_h2c.h
Browse files Browse the repository at this point in the history 
This commit fixes the following checkpatch.pl warning:

    WARNING: do not add new typedefs
    torvalds#251: FILE: include/hal_com_h2c.h:251:
    +typedef struct _RSVDPAGE_LOC {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
  • Loading branch information
@intel-lab-lkp
Marco Cesati authored and intel-lab-lkp committed Mar 12, 2021
1 parent 59dd13c commit 2b62edf
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
20 changes: 10 additions & 10 deletions drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ void CheckFwRsvdPageContent(struct adapter *Adapter)
{
}

static void rtl8723b_set_FwRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc)
static void rtl8723b_set_FwRsvdPage_cmd(struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc)
{
u8 u1H2CRsvdPageParm[H2C_RSVDPAGE_LOC_LEN] = {0};

Expand All @@ -851,7 +851,7 @@ static void rtl8723b_set_FwRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_LOC
FillH2CCmd8723B(padapter, H2C_8723B_RSVD_PAGE, H2C_RSVDPAGE_LOC_LEN, u1H2CRsvdPageParm);
}

static void rtl8723b_set_FwAoacRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc)
static void rtl8723b_set_FwAoacRsvdPage_cmd(struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc)
{
#ifdef CONFIG_WOWLAN
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
Expand Down Expand Up @@ -891,7 +891,7 @@ static void rtl8723b_set_FwAoacRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_

#ifdef CONFIG_AP_WOWLAN
static void rtl8723b_set_ap_wow_rsvdpage_cmd(
struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc
struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc
)
{
u8 header;
Expand Down Expand Up @@ -1284,7 +1284,7 @@ static void rtl8723b_set_FwAOACGlobalInfo_Cmd(struct adapter *padapter, u8 grou
}

#ifdef CONFIG_PNO_SUPPORT
static void rtl8723b_set_FwScanOffloadInfo_cmd(struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc, u8 enable)
static void rtl8723b_set_FwScanOffloadInfo_cmd(struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc, u8 enable)
{
u8 u1H2CScanOffloadInfoParm[H2C_SCAN_OFFLOAD_CTRL_LEN] = {0};

Expand Down Expand Up @@ -1444,7 +1444,7 @@ static void rtl8723b_set_FwRsvdPagePkt(
u8 TotalPageNum = 0, CurtPktPageNum = 0, RsvdPageNum = 0;
u16 BufIndex, PageSize = 128;
u32 TotalPacketLen, MaxRsvdPageBufSize = 0;
RSVDPAGE_LOC RsvdPageLoc;
struct RSVDPAGE_LOC RsvdPageLoc;
#ifdef CONFIG_WOWLAN
u32 ARPLegnth = 0, GTKLegnth = 0;
u8 currentip[4];
Expand Down Expand Up @@ -1474,7 +1474,7 @@ static void rtl8723b_set_FwRsvdPagePkt(
}

ReservedPagePacket = pcmdframe->buf_addr;
memset(&RsvdPageLoc, 0, sizeof(RSVDPAGE_LOC));
memset(&RsvdPageLoc, 0, sizeof(struct RSVDPAGE_LOC));

/* 3 (1) beacon */
BufIndex = TxDescOffset;
Expand Down Expand Up @@ -1829,7 +1829,7 @@ static void rtl8723b_set_AP_FwRsvdPagePkt(
u8 currentip[4];
u16 BufIndex, PageSize = 128;
u32 TotalPacketLen = 0, MaxRsvdPageBufSize = 0;
RSVDPAGE_LOC RsvdPageLoc;
struct RSVDPAGE_LOC RsvdPageLoc;

/* DBG_871X("%s---->\n", __func__); */
DBG_8192C("+" FUNC_ADPT_FMT ": iface_type =%d\n",
Expand All @@ -1851,7 +1851,7 @@ static void rtl8723b_set_AP_FwRsvdPagePkt(
}

ReservedPagePacket = pcmdframe->buf_addr;
memset(&RsvdPageLoc, 0, sizeof(RSVDPAGE_LOC));
memset(&RsvdPageLoc, 0, sizeof(struct RSVDPAGE_LOC));

/* 3 (1) beacon */
BufIndex = TxDescOffset;
Expand Down Expand Up @@ -2136,7 +2136,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter)
u8 TotalPageNum = 0, CurtPktPageNum = 0, RsvdPageNum = 0;
u16 BufIndex, PageSize;
u32 TotalPacketLen, MaxRsvdPageBufSize = 0;
RSVDPAGE_LOC RsvdPageLoc;
struct RSVDPAGE_LOC RsvdPageLoc;


/* DBG_8192C("+" FUNC_ADPT_FMT "\n", FUNC_ADPT_ARG(padapter)); */
Expand All @@ -2156,7 +2156,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter)
}

ReservedPagePacket = pcmdframe->buf_addr;
memset(&RsvdPageLoc, 0, sizeof(RSVDPAGE_LOC));
memset(&RsvdPageLoc, 0, sizeof(struct RSVDPAGE_LOC));

/* 3 (1) beacon */
BufIndex = TxDescOffset;
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/rtl8723bs/include/hal_com_h2c.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ enum h2c_cmd {
/* */
/* Structure -------------------------------------------------- */
/* */
typedef struct _RSVDPAGE_LOC {
struct RSVDPAGE_LOC {
u8 LocProbeRsp;
u8 LocPsPoll;
u8 LocNullData;
Expand All @@ -275,7 +275,7 @@ typedef struct _RSVDPAGE_LOC {
#ifdef CONFIG_AP_WOWLAN
u8 LocApOffloadBCN;
#endif /* CONFIG_AP_WOWLAN */
} RSVDPAGE_LOC, *PRSVDPAGE_LOC;
};

#endif
#if defined(CONFIG_WOWLAN) || defined(CONFIG_AP_WOWLAN)
Expand Down

0 comments on commit 2b62edf

Please sign in to comment.