Skip to content

Commit

Permalink
mm-convert-totalram_pages-and-totalhigh_pages-variables-to-atomic-che…
Browse files Browse the repository at this point in the history
…ckpatch-fixes

WARNING: 'lenght' may be misspelled - perhaps 'length'?
torvalds#7:
things.  It was discussed in lenght here,

WARNING: line over 80 characters
torvalds#252: FILE: drivers/md/dm-crypt.c:2161:
+	unsigned long pages = (totalram_pages() - totalhigh_pages()) * DM_CRYPT_MEMORY_PERCENT / 100;

WARNING: line over 80 characters
torvalds#263: FILE: drivers/md/dm-integrity.c:2846:
+	if (journal_pages >= totalram_pages() - totalhigh_pages() || journal_desc_size > ULONG_MAX) {

WARNING: line over 80 characters
torvalds#307: FILE: drivers/parisc/ccio-dma.c:1254:
+	iova_space_size = (u32) (totalram_pages() / count_parisc_driver(&ccio_driver));

WARNING: please, no spaces at the start of a line
torvalds#472: FILE: include/linux/highmem.h:47:
+       atomic_long_inc(&_totalhigh_pages);$

WARNING: please, no spaces at the start of a line
torvalds#477: FILE: include/linux/highmem.h:52:
+       atomic_long_dec(&_totalhigh_pages);$

WARNING: please, no spaces at the start of a line
torvalds#482: FILE: include/linux/highmem.h:57:
+       atomic_long_add(count, &_totalhigh_pages);$

WARNING: please, no spaces at the start of a line
torvalds#487: FILE: include/linux/highmem.h:62:
+       atomic_long_set(&_totalhigh_pages, val);$

WARNING: please, no spaces at the start of a line
torvalds#511: FILE: include/linux/mm.h:54:
+       return (unsigned long)atomic_long_read(&_totalram_pages);$

WARNING: please, no spaces at the start of a line
torvalds#516: FILE: include/linux/mm.h:59:
+       atomic_long_inc(&_totalram_pages);$

WARNING: please, no spaces at the start of a line
torvalds#521: FILE: include/linux/mm.h:64:
+       atomic_long_dec(&_totalram_pages);$

WARNING: please, no spaces at the start of a line
torvalds#526: FILE: include/linux/mm.h:69:
+       atomic_long_add(count, &_totalram_pages);$

WARNING: please, no spaces at the start of a line
torvalds#531: FILE: include/linux/mm.h:74:
+       atomic_long_set(&_totalram_pages, val);$

WARNING: line over 80 characters
torvalds#722: FILE: mm/page_alloc.c:7288:
+		(physpages - totalram_pages() - totalcma_pages) << (PAGE_SHIFT - 10),

WARNING: Missing a blank line after declarations
torvalds#745: FILE: mm/shmem.c:118:
+	unsigned long nr_pages = totalram_pages();
+	return min(nr_pages - totalhigh_pages(), nr_pages / 2);

total: 0 errors, 15 warnings, 656 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-convert-totalram_pages-and-totalhigh_pages-variables-to-atomic.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Arun KS <arunks@codeaurora.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
  • Loading branch information
akpm00 authored and sfrothwell committed Dec 15, 2018
1 parent ed57134 commit 54ab5f5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
8 changes: 4 additions & 4 deletions include/linux/highmem.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,22 +44,22 @@ static inline unsigned long totalhigh_pages(void)

static inline void totalhigh_pages_inc(void)
{
atomic_long_inc(&_totalhigh_pages);
atomic_long_inc(&_totalhigh_pages);
}

static inline void totalhigh_pages_dec(void)
{
atomic_long_dec(&_totalhigh_pages);
atomic_long_dec(&_totalhigh_pages);
}

static inline void totalhigh_pages_add(long count)
{
atomic_long_add(count, &_totalhigh_pages);
atomic_long_add(count, &_totalhigh_pages);
}

static inline void totalhigh_pages_set(long val)
{
atomic_long_set(&_totalhigh_pages, val);
atomic_long_set(&_totalhigh_pages, val);
}

void kmap_flush_unused(void);
Expand Down
10 changes: 5 additions & 5 deletions include/linux/mm.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,27 +51,27 @@ static inline void set_max_mapnr(unsigned long limit) { }
extern atomic_long_t _totalram_pages;
static inline unsigned long totalram_pages(void)
{
return (unsigned long)atomic_long_read(&_totalram_pages);
return (unsigned long)atomic_long_read(&_totalram_pages);
}

static inline void totalram_pages_inc(void)
{
atomic_long_inc(&_totalram_pages);
atomic_long_inc(&_totalram_pages);
}

static inline void totalram_pages_dec(void)
{
atomic_long_dec(&_totalram_pages);
atomic_long_dec(&_totalram_pages);
}

static inline void totalram_pages_add(long count)
{
atomic_long_add(count, &_totalram_pages);
atomic_long_add(count, &_totalram_pages);
}

static inline void totalram_pages_set(long val)
{
atomic_long_set(&_totalram_pages, val);
atomic_long_set(&_totalram_pages, val);
}

extern void * high_memory;
Expand Down
1 change: 1 addition & 0 deletions mm/shmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ static unsigned long shmem_default_max_blocks(void)
static unsigned long shmem_default_max_inodes(void)
{
unsigned long nr_pages = totalram_pages();

return min(nr_pages - totalhigh_pages(), nr_pages / 2);
}
#endif
Expand Down

0 comments on commit 54ab5f5

Please sign in to comment.