Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to ethpandaops/ethereum-package + a few ci fixes #153

Merged
merged 12 commits into from
Jun 14, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Jun 13, 2024

Description

The ethereum-package has migrated from Kurtosis to the EF.

Notes:

  • The cdk-erigon job fails because there was a typo in the workflow file and since this PR relies on pull_request_target, it will fail until we merge the fix.

  • There's another issue since we upgraded the kurtosis version. Kurtosis now checks that port names follow the RFC-6335 standard. It means that port names should be maximum 15 characters long. However, some of the blockscout services names are too long (Change service name to avoid kurtosis-cdk RFC 6335 error (length) xavier-romero/kurtosis-blockscout#4). Thus incremental fails because it deploys all the different components (note that pre-deployed-contracts also fails because it wrongly deploys all the components - this is fixed but it will reflect only after this PR has been merged).

Screenshot 2024-06-14 at 15 03 36

References (if applicable)

@leovct leovct changed the title chore: migrate to ethpandaops/ethereum-package chore: migrate to ethpandaops/ethereum-package + a few ci fix Jun 14, 2024
@leovct leovct enabled auto-merge (squash) June 14, 2024 17:05
@leovct leovct changed the title chore: migrate to ethpandaops/ethereum-package + a few ci fix chore: migrate to ethpandaops/ethereum-package + a few ci fixes Jun 14, 2024
@leovct leovct disabled auto-merge June 14, 2024 17:05
@leovct leovct enabled auto-merge (squash) June 14, 2024 17:05
Copy link
Contributor

@rebelArtists rebelArtists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leovct leovct merged commit 8898ab7 into 0xPolygon:main Jun 14, 2024
11 of 14 checks passed
@leovct leovct deleted the chore/migrate-to-new-eth-pkg branch June 16, 2024 16:56
jarrodwatts pushed a commit to jarrodwatts/kurtosis-cdk that referenced this pull request Jun 27, 2024
…Polygon#153)

* chore: migrate to `ethpandaops/ethereum-package`

* chore: bump pkg version

* chore: bump kurtosis version

* fix: typo

* chore: test

* test: 4.0.0

* chore: clean up

* chore: bump to kurtosis-tech `0.90.1`

* ci: fix typo

* doc: fix typo

* fix: pre-deployed-contracts job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants