Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sovereign bridge implementation #330

Open
wants to merge 11 commits into
base: feature/ongoingPP
Choose a base branch
from
Open

Sovereign bridge implementation #330

wants to merge 11 commits into from
+4,164 −10

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Sep 16, 2024 •
edited
Loading

Create Bridge and GlobalExitRootManager contracts for Sovereign chains + tests.
BridgeL2SovereignChain.sol : extends from PolygonZkEVMBridgeV2 with the features of:

  • Set a bridgeManager address
  • Functions to remap and undo remap of token addresses by sovereign token addresses
  • Overrided mint/burn functions from BridgeV2 to handle that new remapping

GlobalExitRootManagerL2SovereignChain.sol : extends from PolygonZkEVMGlobalExitRootL2 with the features of:

  • New function insertGlobalExitRoot only callable by coinbase to update the GER of a Sovereign Chain

@cla-bot cla-bot bot added the cla-signed label Sep 16, 2024
@ignasirv ignasirv force-pushed the feature/sovereign-bridge branch 2 times, most recently from c79a5d0 to 45319de Compare September 16, 2024 14:20
@ignasirv
Full testing coverage for sovereign contracts
f6ee3ba
@ignasirv
Added sovereign bridge features
a73bba5 
- Batch call function implementation to remap multiple tokens
- Allow migrating legacy to updated tokens natively
- Added weth mapped address are initializer
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
57.5% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata Awaiting requested review from krlosMata krlosMata is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignasirv @invocamanman