Skip to content

Commit

Permalink
remove unused import, capitalize immutable, explicit visibility
Browse files Browse the repository at this point in the history
  • Loading branch information
smarx committed Nov 5, 2020
1 parent 3221c85 commit 80fbd28
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions contracts/zero-ex/contracts/src/ZeroEx.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@
pragma solidity ^0.6.5;
pragma experimental ABIEncoderV2;

import "./migrations/LibBootstrap.sol";
import "./features/BootstrapFeature.sol";
import "./storage/LibProxyStorage.sol";

/// @dev An extensible proxy contract that serves as a universal entry point for
/// interacting with the 0x protocol.
contract ZeroEx {
uint256 immutable immutableImplsSlot;
uint256 immutable private IMMUTABLE_IMPLS_SLOT;

/// @dev Construct this contract and register the `BootstrapFeature` feature.
/// After constructing this contract, `bootstrap()` should be called
Expand All @@ -45,7 +44,7 @@ contract ZeroEx {
// local.
uint256 implsSlot;
assembly { implsSlot := impls_slot }
immutableImplsSlot = implsSlot;
IMMUTABLE_IMPLS_SLOT = implsSlot;
}


Expand All @@ -54,7 +53,7 @@ contract ZeroEx {
/// @dev Forwards calls to the appropriate implementation contract.
fallback() external payable {
// Yul can't directly access immutables.
uint256 implsSlot = immutableImplsSlot;
uint256 implsSlot = IMMUTABLE_IMPLS_SLOT;

assembly {
let cdlen := calldatasize()
Expand Down

0 comments on commit 80fbd28

Please sign in to comment.