fix: Ban colliding Kyber reserve

0xProject · Apr 29, 2021 · a7bb68f · a7bb68f
1 parent fe0c263
commit a7bb68f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/asset-swapper/src/utils/market_operation_utils/bridge_source_utils.ts b/packages/asset-swapper/src/utils/market_operation_utils/bridge_source_utils.ts
@@ -8,6 +8,7 @@ import {
     CRYPTO_COM_ROUTER_BY_CHAIN_ID,
     CURVE_MAINNET_INFOS,
     ELLIPSIS_BSC_INFOS,
+    KYBER_BANNED_RESERVES,
     KYBER_BRIDGED_LIQUIDITY_PREFIX,
     KYBER_DMM_ROUTER_BY_CHAIN_ID,
     MAX_DODOV2_POOLS_QUERIED,
@@ -32,7 +33,11 @@ import { CurveInfo, ERC20BridgeSource } from './types';
  * @param reserveId Kyber reserveId
  */
 export function isAllowedKyberReserveId(reserveId: string): boolean {
-    return reserveId !== NULL_BYTES && !reserveId.startsWith(KYBER_BRIDGED_LIQUIDITY_PREFIX);
+    return (
+        reserveId !== NULL_BYTES &&
+        !reserveId.startsWith(KYBER_BRIDGED_LIQUIDITY_PREFIX) &&
+        !KYBER_BANNED_RESERVES.includes(reserveId)
+    );
 }
 
 // tslint:disable-next-line: completed-docs ban-types

diff --git a/packages/asset-swapper/src/utils/market_operation_utils/constants.ts b/packages/asset-swapper/src/utils/market_operation_utils/constants.ts
@@ -744,6 +744,7 @@ export const NERVE_BSC_INFOS: { [name: string]: CurveInfo } = {
  * 0xbb Bridged price reserve (i.e Uniswap/Curve)
  */
 export const KYBER_BRIDGED_LIQUIDITY_PREFIX = '0xbb';
+export const KYBER_BANNED_RESERVES = ['0xff4f6e65426974205175616e7400000000000000000000000000000000000000'];
 export const MAX_KYBER_RESERVES_QUERIED = 5;
 export const KYBER_CONFIG_BY_CHAIN_ID = valueByChainId<KyberSamplerOpts>(
     {