Feature/liquidity provider sandbox #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
requested review from
abandeali1,
BMillman19,
dave4506,
dorothy-zbornak and
hysz
as code owners
packages/asset-swapper/src/utils/market_operation_utils/sampler_operations.ts
Show resolved
Hide resolved
packages/asset-swapper/src/utils/market_operation_utils/sampler_operations.ts
Show resolved
Hide resolved
packages/asset-swapper/src/quote_consumers/exchange_proxy_swap_quote_consumer.ts
Outdated
Show resolved
Hide resolved
packages/asset-swapper/src/quote_consumers/exchange_proxy_swap_quote_consumer.ts
Outdated
Show resolved
Hide resolved
contracts/zero-ex/contracts/src/features/ILiquidityProviderFeature.sol
Outdated
Show resolved
Hide resolved
contracts/zero-ex/contracts/src/features/ILiquidityProviderFeature.sol
Outdated
Show resolved
Hide resolved
| public | ||
| FixinCommon() | ||
| { | ||
| weth = weth_; | ||
| sandbox = new LiquidityProviderSandbox(zeroEx); |
There was a problem hiding this comment.
Wouldn't we rather pass in the sandbox so we can reuse an older one and avoid having to whitelist a new one every time we make a change to this feature?
There was a problem hiding this comment.
yeah I was thinking in the next iteration of this feature, sandbox would be passed in as a constructor arg. no need to pass it in for this first version though, might as well deploy it in the same txn
|
think a rebase will fix the |
moodlezoup
force-pushed
the
feature/liquidity_provider_sandbox
branch
from
8849fc3
to
ca8e066
Compare
moodlezoup
force-pushed
the
feature/liquidity_provider_sandbox
branch
from
b93330e
to
c4458bb
Compare
|
Has this been simbotted btw? |
moodlezoup
force-pushed
the
feature/liquidity_provider_sandbox
branch
from
ace05ce
to
32e1bd0
Compare
moodlezoup
force-pushed
the
feature/liquidity_provider_sandbox
branch
2 times, most recently
from
d09a6ab
to
b40eee5
Compare
dorothy-zbornak
force-pushed
the
feature/liquidity_provider_sandbox
branch
from
b40eee5
to
06295c4
Compare
moodlezoup
added a commit
that referenced
this pull request
Nov 14, 2020
This reverts commit 7403c02.
moodlezoup
added a commit
that referenced
this pull request
Nov 14, 2020
This reverts commit 7403c02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ILiquidityProviderinterfaceProtocolFeeUnfundedevent in FQTTesting instructions
Types of changes
Checklist:
[WIP]if necessary.