Rename {Rfqt=>Rfq} for types in Asset Swapper #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-ociraptor
commented
Mar 18, 2021
packages/asset-swapper/src/types.ts
Outdated
| nativeExclusivelyRFQT?: boolean; | ||
| altRfqtAssetOfferings?: AltRfqtMakerAssetOfferings; | ||
| nativeExclusivelyRFQ?: boolean; | ||
| altRfqtAssetOfferings?: AltRfqMakerAssetOfferings; |
There was a problem hiding this comment.
left this field to be called altRfqtAssetOfferings because not sure if this will be separate for RFQT and RFQM
There was a problem hiding this comment.
I think we should rename it if we're making this type RFQ-T or M agnostic
phil-ociraptor
commented
Mar 18, 2021
| } | ||
|
|
||
| /** | ||
| * gasPrice: gas price to determine protocolFee amount, default to ethGasStation fast amount | ||
| */ | ||
| export interface SwapQuoteRequestOpts extends GetMarketOrdersOpts { | ||
| gasPrice?: BigNumber; | ||
| rfqt?: RfqtRequestOpts; | ||
| rfqt?: RfqRequestOpts; |
There was a problem hiding this comment.
also left this field to be called rfqt because I imagine there might be a separate field for rfqm but not sure
There was a problem hiding this comment.
this should be left rfqt bc RFQM will be separate from swapQuoter
phil-ociraptor
commented
Mar 18, 2021
| @@ -119,7 +119,7 @@ export async function returnQuoteFromAltMMAsync<ResponseT>( | |||
| makerToken: string, | |||
| takerToken: string, | |||
| maxResponseTimeMs: number, | |||
| altRfqtAssetOfferings: AltRfqtMakerAssetOfferings, | |||
| altRfqtAssetOfferings: AltRfqMakerAssetOfferings, | |||
There was a problem hiding this comment.
this field might need to be renamed?
There was a problem hiding this comment.
yea best to rename this as well
PirosB3
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Super tiny change to make Rfqt=>Rfq for types in Asset Swapper. This is because these types will be reused for RFQM
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.