Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yoshi Exchange support (Fantom) [TKR-270] #473

Merged
merged 2 commits into from
May 18, 2022
Merged

Conversation

kyu-c
Copy link
Collaborator

@kyu-c kyu-c commented May 11, 2022

Description

Add Yoshi Exchange support in Fantom

Testing instructions

Run 0x-api locally.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@kyu-c kyu-c changed the title [WIP] Add Yoshi Exchange support (Fantom) [TKR-270] Add Yoshi Exchange support (Fantom) [TKR-270] May 11, 2022
@kyu-c kyu-c requested review from dekz and dextracker May 11, 2022 00:44
Copy link
Contributor

@dextracker dextracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another spotless PR 🎉 LGTM

@dekz
Copy link
Member

dekz commented May 18, 2022

Nice one! Might need to rebase off of development to address these conflicts.

@kyu-c kyu-c merged commit fedb531 into development May 18, 2022
@kyu-c kyu-c deleted the feat/fantom/yoshi branch May 18, 2022 23:58
dextracker pushed a commit that referenced this pull request Jun 15, 2022
* Resolve conflicts

* Update CHANGELOG.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants