Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Velodrome support [TKR-432] #494

Merged
merged 10 commits into from
Jun 13, 2022
Merged

feat: Add Velodrome support [TKR-432] #494

merged 10 commits into from
Jun 13, 2022

Conversation

kyu-c
Copy link
Collaborator

@kyu-c kyu-c commented Jun 7, 2022

Description

  • Add Velodrome support in Optimism

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@kyu-c kyu-c requested review from dekz and dextracker and removed request for moodlezoup and abandeali1 June 7, 2022 20:40
@kyu-c kyu-c changed the title feat: Add Velodrome support feat: Add Velodrome support [TKR-432] Jun 7, 2022
Copy link
Contributor

@dextracker dextracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great job 🎉

Add a new entry to the changelog in AS and we should be good to go

@kyu-c kyu-c merged commit 1cc59ab into development Jun 13, 2022
@kyu-c kyu-c deleted the feat/op/velo branch June 13, 2022 18:55
dextracker pushed a commit that referenced this pull request Jun 15, 2022
* Implement MixinVelodrome

* Add preliminary implementation of VelodromeSampler

* Add Velodrome in BridgeProtocol of transformer_utils.ts

* Fix MixinVelodrome

* Wire Velodrome sampler in market_operation_utils

* Fix lint error

* Remove gas schedule TODO

* Format VelodromeSampler.sol

* Fix MixinVelodrome

* Update CHANGELOG.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants