Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary fetching script #425

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fix binary fetching script #425

merged 2 commits into from
Apr 15, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 15, 2024

Usage related changes

  • None

Development related changes

  • The binary fetching script could so far only download the artifacts of latest main workflow, which is a problem if its commit message contains [skip ci]. Now it defaults to the latest successful main workflow, and also supports providing a workflow ID via scripts/fetch_ci_binaries.py --workflow <ID>.
  • Readme also improved.

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC requested a review from mikiw April 15, 2024 11:06
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work perfectly, good job!

@FabijanC FabijanC merged commit 20a256f into main Apr 15, 2024
@FabijanC FabijanC deleted the fix-binary-fetch-script branch April 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants