Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calling commit_with_diff from generate_new_block_and_state #503

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Remove calling commit_with_diff from generate_new_block_and_state #503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3659957
remove of self.commit_with_diff
Jun 18, 2024
20dff08
Merge branch 'main' into remove-of-commit-diff
Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions crates/starknet-devnet-core/src/starknet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,6 @@ impl Starknet {
// insert pending block in the blocks collection and connect it to the state diff
self.blocks.insert(new_block, state_diff);

// clone_historic() requires self.historic_state, self.historic_state is set in
// expand_historic(), expand_historic() can be executed from commit_with_diff() - this
// is why self.commit_with_diff()? is here
self.commit_with_diff()?;

// save into blocks state archive
if self.config.state_archive == StateArchiveCapacity::Full {
let clone = self.pending_state.clone_historic();
Expand Down