Abort blocks by ID #541
Merged
Abort blocks by ID #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikiw
reviewed
Jul 8, 2024
mikiw
suggested changes
Jul 8, 2024
FabijanC
requested changes
Jul 8, 2024
3alpha
force-pushed
the
add-abort-by-number
branch
from
1fb707a
to
8f59283
Compare
|
Added testing for aborting on tag, If I am not missing something, aborting on tag looks pretty straight forward. |
3alpha
force-pushed
the
add-abort-by-number
branch
from
448b013
to
b26ae3f
Compare
FabijanC
requested changes
Jul 10, 2024
3alpha
commented
Jul 10, 2024
|
@3alpha I see that good PR is cooking, once you finish please send the re-request review (the right top of page) |
mikiw
approved these changes
Jul 11, 2024
FabijanC
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Adds functionality so that blocks can be aborted by number in addition to hash.
Development related changes
Resolves #512
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md