Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrictive mode #558

Merged
merged 43 commits into from
Aug 14, 2024
Merged

Restrictive mode #558

merged 43 commits into from
Aug 14, 2024

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Jul 18, 2024 •
edited
Loading

Usage related changes

Users can start devnet with cli argument --restrictive-mode or --restrictive-mode <method_1> <method_2>

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please prefer merging over rebasing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@marioiordanov marioiordanov marked this pull request as ready for review July 18, 2024 07:20
@marioiordanov marioiordanov linked an issue Jul 18, 2024 that may be closed by this pull request
Restrictive flags needed for running Devnet in an untrusted environment #511
Closed
FabijanC
FabijanC requested changes Jul 18, 2024
View reviewed changes
website/docs/restrictive.md Outdated Show resolved Hide resolved
website/docs/restrictive.md Outdated Show resolved Hide resolved
website/docs/restrictive.md Show resolved Hide resolved
website/docs/restrictive.md Outdated Show resolved Hide resolved
website/docs/restrictive.md Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/rpc_handler.rs Show resolved Hide resolved
crates/starknet-devnet-server/src/server.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/restrictive_methods.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/api/json_rpc/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Outdated Show resolved Hide resolved
mikiw
mikiw suggested changes Jul 19, 2024
View reviewed changes
crates/starknet-devnet-server/src/api/json_rpc/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/server.rs Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Show resolved Hide resolved
FabijanC
FabijanC requested changes Aug 13, 2024
View reviewed changes
crates/starknet-devnet/tests/test_restrictive_mode.rs Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Show resolved Hide resolved
@marioiordanov marioiordanov merged commit 02e12cf into main Aug 14, 2024
1 check passed
@marioiordanov marioiordanov deleted the restrictive branch August 14, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikiw mikiw mikiw requested changes

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrictive flags needed for running Devnet in an untrusted environment
3 participants
@marioiordanov @mikiw @FabijanC