Time manipulation functions #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- increaseTime() - setTime()
| }, "Request failed. Make sure your network has the /increase_time endpoint"); | ||
| } | ||
|
|
||
| public async setTime(seconds: number) { |
There was a problem hiding this comment.
Do you think it would make sense to provide an option to set time in Date as well? Or does it make more sense to expect users to do the date manipulation anyway?
badurinantun
suggested changes
May 30, 2022
FabijanC
requested changes
May 31, 2022
FabijanC
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
increaseTime()andsetTime()Development related changes
setTime()wil update the subsequent block timestamp keeping the offsetChecklist:
pluginbranch ofstarknet-hardhat-example.