Relative artifacts #118
Merged
Relative artifacts #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
reviewed
Jun 7, 2022
scripts/test.sh
Outdated
| @@ -9,7 +9,7 @@ CONFIG_FILE_NAME="hardhat.config.ts" | |||
|
|
|||
| # setup example repo | |||
| rm -rf starknet-hardhat-example | |||
| git clone -b plugin --single-branch git@github.com:Shard-Labs/starknet-hardhat-example.git | |||
| git clone -b relativeArtifacts --single-branch git@github.com:Shard-Labs/starknet-hardhat-example.git | |||
There was a problem hiding this comment.
TODO: change before merge
There was a problem hiding this comment.
@epShardlabs You can change this back to plugin as your example repo PR has been merged.
FabijanC
requested changes
Jun 9, 2022
FabijanC
requested changes
Jun 20, 2022
| "$schema": "../../network.schema", | ||
| "alpha": true, | ||
| "devnet": true | ||
| } |
There was a problem hiding this comment.
GitHub is reporting a missing newline.
scripts/test.sh
Outdated
| @@ -9,7 +9,7 @@ CONFIG_FILE_NAME="hardhat.config.ts" | |||
|
|
|||
| # setup example repo | |||
| rm -rf starknet-hardhat-example | |||
| git clone -b plugin --single-branch git@github.com:Shard-Labs/starknet-hardhat-example.git | |||
| git clone -b relativeArtifacts --single-branch git@github.com:Shard-Labs/starknet-hardhat-example.git | |||
There was a problem hiding this comment.
@epShardlabs You can change this back to plugin as your example repo PR has been merged.
FabijanC
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
getContractFactorynow can process relative path to artifact thus enabling load from outside specified/default artifact folder.Checklist:
pluginbranch ofstarknet-hardhat-example: Relative artifacts tests starknet-hardhat-example#63