Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to cairo-lang 0.9.0 #124

Merged
merged 40 commits into from
Jun 27, 2022
Merged

Adapt to cairo-lang 0.9.0 #124

merged 40 commits into from
Jun 27, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jun 17, 2022

Usage related changes

  • Fixed interaction with localhost when using dockerizedVersion:
    • If using WSL
    • When doing tx_status and similar calls (was missing adaptUrl in starknetWrapper).
  • cairo-lang 0.9.0 updates:
    • Added class declaration functionality (CLI command and StarknetFactory.declare method).
  • Updated OZ Account version used
  • Argent account changes:

Development related changes

  • Removed some tests from testing on alpha-goerli.
  • In account-test/check.sh:
    • Separated running of hardhat test for OZ and Argent account.
    • Added commands that deploy, initialize and fund an argent account token (only executed on devnet since there we don't have a prefunded Argent account, just OZ)
  • Update starknet-verify test to use the same compiler version for compiling and and verification (0.8.1).
  • Added isWsl dependency.
  • Upgraded the starknet.js version used (had to change string to StarknetChainId in some places).
  • Since maxFee is enforced on alpha-goerli, we now use an OZ and an Argent account with funds:
    • These env vars are to be stored in the shardlabs context on CircleCI.
    • Names of vars can be found in set-devnet-vars.sh and set-alpha-vars.sh.
  • Isolated devnet tests one from the other:
    • Devnet is started before each check.sh and killed after it (in tests that have devnet: true in their network.json).
  • Updated to hardhat 2.9.9
  • Updated to starknet.js 3.15.0:
    • New hash function does not accept negative values, so now we use modular equivalents of negatives (shouldn't be any difference for users).

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example: Adapt to 0.9.0 starknet-hardhat-example#65
  • All tests passing
  • I have added the CircleCI account env vars
  • I have restored the example-repo branch specified in test.sh

@FabijanC FabijanC requested a review from Nathan-SL June 23, 2022 15:31
@FabijanC FabijanC marked this pull request as ready for review June 23, 2022 16:38
@FabijanC FabijanC merged commit 97a5c87 into master Jun 27, 2022
@FabijanC FabijanC deleted the adapt-0.9.0 branch June 27, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deploy Argent Account Argent Account not working in js Error with account.call
1 participant