-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decodeEvents function #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qperrot
force-pushed
the
decode-getTransactionReceipt
branch
from
June 29, 2022 14:28
a1162b1
to
339ba98
Compare
FabijanC
requested changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the checklist, you said you modified the test
directory, but I don't see any changes to it. Your example repo test never got executed because you didn't introduce a test case for it here, in the plugin repo (remember your last PR and how there has to be a check.sh script).
account-contract-artifacts/ArgentAccount/0.2.2/ArgentAccount.cairo/ArgentAccount.json
Outdated
Show resolved
Hide resolved
FabijanC
reviewed
Jul 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
starknet-hardhat-example
] (add decode events test starknet-hardhat-example#68)Development related changes
Checklist:
test
directoryplugin
branch ofstarknet-hardhat-example
:test.sh
to use my example repo branchtest.sh
to to use the original branch (after the example repo PR has been merged)