Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decodeEvents function #130

Merged
merged 7 commits into from
Jul 5, 2022
Merged

Add decodeEvents function #130

merged 7 commits into from
Jul 5, 2022

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Jun 29, 2022

Usage related changes

Development related changes

Checklist:

  • Formatted the code
  • No linter errors
  • Tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing

@qperrot qperrot force-pushed the decode-getTransactionReceipt branch from a1162b1 to 339ba98 Compare June 29, 2022 14:28
@qperrot qperrot requested a review from FabijanC June 29, 2022 15:09
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the checklist, you said you modified the test directory, but I don't see any changes to it. Your example repo test never got executed because you didn't introduce a test case for it here, in the plugin repo (remember your last PR and how there has to be a check.sh script).

src/starknet-types.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/extend-utils.ts Outdated Show resolved Hide resolved
src/type-extensions.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@qperrot qperrot requested a review from FabijanC July 4, 2022 10:53
src/types.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC changed the title add decodeEvents function Add decodeEvents function Jul 5, 2022
@FabijanC FabijanC merged commit 8551649 into master Jul 5, 2022
@FabijanC FabijanC deleted the decode-getTransactionReceipt branch July 5, 2022 10:17
@FabijanC FabijanC mentioned this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants