Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exiting in integrated-devnet #132

Merged
merged 14 commits into from
Jul 7, 2022
Merged

Fix exiting in integrated-devnet #132

merged 14 commits into from
Jul 7, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jun 30, 2022

Usage related changes

  • Log message if integrated-devnet exits with status code not equal to zero.

Development related changes

  • Added tests that expect integrated-devnet failure (if wrong cli parameters or address occupied, for both venv and docker).
  • Removed the --detach flag from the dockerized integrated devnet
  • It is still handled correctly, but allows us to use the subprocess return by the docker (with --detach, it would spawn the container in background and that spawner process would die immediatelly after spawning)
  • Drew inspiration from fix: add error checks for integrated devnet process #133.

Checklist:

  • Formatted the code
  • No linter errors
  • Tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory
  • All tests are passing

@FabijanC FabijanC requested review from Nathan-SL and removed request for Nathan-SL July 6, 2022 13:30
@FabijanC FabijanC marked this pull request as ready for review July 6, 2022 14:58
@FabijanC FabijanC requested a review from Nathan-SL July 6, 2022 15:27
Copy link
Contributor

@Nathan-SL Nathan-SL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@FabijanC FabijanC merged commit 2c986d0 into master Jul 7, 2022
@FabijanC FabijanC deleted the integrated-devnet-exit branch July 7, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants