Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenZeppelin account artifacts to v0.2.1 #169

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

amanusk
Copy link
Contributor

@amanusk amanusk commented Jul 17, 2022

Updates OpenZeppelin account version to 0.2.1
Fixes #161

Usage related changes

  • Use v0.2.1 of OpenZeppelin accounts

Development related changes

  • Running npx hardhat test --no-compile test/oz-account-test.ts should now pass with both devnet and alpha-goerli

Checklist:

  • Formatted the code
  • No linter errors
  • Tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.sh)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Updates OpenZeppelin account version to 0.2.1
Fixes issue 0xSpaceShard#161
@FabijanC FabijanC self-requested a review July 18, 2022 09:54
@FabijanC
Copy link
Collaborator

The ABI is the same as it was for 0.2.0?

@amanusk
Copy link
Contributor Author

amanusk commented Jul 18, 2022

Yes, the ABI is the same. Checked with diff..

Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve & merge this when you can confirm that you successfully ran quick-test.ts and oz-account-test.ts from starknet-hardhat-example with this new account artifact.

@amanusk
Copy link
Contributor Author

amanusk commented Jul 19, 2022

Tests are passing, and also running npm run test-general-tests is passing

@FabijanC FabijanC self-requested a review July 19, 2022 11:11
@FabijanC FabijanC merged commit 4fc9d2d into 0xSpaceShard:master Jul 19, 2022
@martriay
Copy link

Yes, the ABI is the same. Checked with diff..

Can confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenZeppeling 0.2.0 account contract have an issue with signature verification.
3 participants