Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new chain ID for Alpha Goerli 2 #267

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Support new chain ID for Alpha Goerli 2 #267

merged 2 commits into from
Dec 7, 2022

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Dec 7, 2022

Usage related changes

  • Closes Support new chain ID #263
  • Adds new enum with new chain ID added for alpha goerli2
  • "alpha-goerli2": StarknetChainId.TESTNET.value, on starknet_cli_legacy.py Should be changed to StarknetChainId.TESTNET2.value when adapting 0.10.3.

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC merged commit 152f685 into master Dec 7, 2022
@FabijanC FabijanC deleted the new-chainid branch December 7, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new chain ID
2 participants