Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor Starknet Wrapper #278

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Dec 14, 2022

Usage related changes

Development related changes

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Copy link
Contributor

@Nathan-SL Nathan-SL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's rebase.

@FabijanC FabijanC merged commit 8caacde into master Dec 15, 2022
@FabijanC FabijanC deleted the fix-starknet-wrapper-url branch December 15, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor StarknetWrapper classes URL adaptation should only be done in DockerWrapper
2 participants