Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow axios timeout configuration via hardhat config #322

Merged
merged 8 commits into from
Feb 23, 2023

Conversation

notV4l
Copy link
Contributor

@notV4l notV4l commented Feb 22, 2023

Usage related changes

Development related changes

  • new parameter in hardhat.config.js
starknet: {
    requestTimeout: 90_000,
}

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should expand test/configuration-tests. No additions would be required to the starknet-hardhat-example repo.

You could introduce two new test cases:
- one with an extremely small timeout (1 ms) and expected to fail
- another with a sufficient timeout (e.g. 30 seconds) and expected to pass

src/external-server/external-server.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC changed the title allow axios timeout configuration via hardhat.config.js Allow axios timeout configuration via hardhat config Feb 23, 2023
@FabijanC FabijanC merged commit e5e0a9f into 0xSpaceShard:master Feb 23, 2023
shramee pushed a commit to shramee/starknet-hardhat-plugin that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow request timeout customization
2 participants