Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide nonce on deploy function #323

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Provide nonce on deploy function #323

merged 3 commits into from
Feb 24, 2023

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Feb 22, 2023 •
edited
Loading

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Add Nonce on deploy starknet-hardhat-example#100
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC merged commit 1c436d1 into master Feb 24, 2023
@FabijanC FabijanC deleted the nonce-on-deploy branch February 24, 2023 08:32
shramee pushed a commit to shramee/starknet-hardhat-plugin that referenced this pull request Feb 26, 2023
@Nathan-SL @shramee
Provide nonce on deploy function (0xSpaceShard#323)
cad8570 
* [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users should be able to provide a nonce when deploying
2 participants
@Nathan-SL @FabijanC