Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Declare Nonce to Starknet CLI #324

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

solimander
Copy link
Contributor

Usage related changes

This PR fixes the following error when passing a custom nonce to a declare transaction via the Account class:

Signature (..., ...), is invalid, with respect to the public key ..., and the message hash ...

This would occur because the message hash with the custom nonce would be signed, while the transaction would be created with the current account nonce. This issue made it nearly impossible to submit multiple declare transactions at the same time.

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC self-requested a review February 24, 2023 08:13
@FabijanC FabijanC merged commit a34fb4a into 0xSpaceShard:master Feb 24, 2023
shramee pushed a commit to shramee/starknet-hardhat-plugin that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants