Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adaptInputUtil function return type #368

Merged
merged 4 commits into from
May 31, 2023
Merged

Update adaptInputUtil function return type #368

merged 4 commits into from
May 31, 2023

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented May 16, 2023 •
edited
Loading

Usage related changes

Breaking change

  • adaptInputUtil return type changed StringMap -> unknown

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Update test due to change in return type  starknet-hardhat-example#111
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL requested a review from FabijanC May 16, 2023 11:05
FabijanC
FabijanC reviewed May 16, 2023
View reviewed changes
src/adapt.ts Show resolved Hide resolved
src/adapt.ts Outdated Show resolved Hide resolved
FabijanC
FabijanC approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just restore the example repo branch

@Nathan-SL Nathan-SL merged commit 86e7865 into master May 31, 2023
@Nathan-SL Nathan-SL deleted the update-return-type branch May 31, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract function calls shouldn't force returning an object
2 participants
@Nathan-SL @FabijanC