Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cairo1 events #380

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Cairo1 events #380

merged 6 commits into from
Jun 20, 2023

Conversation

notV4l
Copy link
Contributor

@notV4l notV4l commented Jun 15, 2023 •
edited by FabijanC
Loading

Fix #378

  • updated declare-v2-test path to match starknet-hardhat-example directory test/cairo1
  • add doc for "Executing individual tests with dockerized environnement"

Corresponding example-repo PR: 0xSpaceShard/starknet-hardhat-example#114

@Nathan-SL
Copy link
Contributor

Nathan-SL commented Jun 15, 2023 •
edited
Loading

@notV4l your PR is still targeting origin/plugin branch of the example repo and that's why your tests are failing. I think you can change the target branch and repo to yours onscripts/test-setup.sh

@FabijanC FabijanC self-requested a review June 15, 2023 10:47
@FabijanC FabijanC mentioned this pull request Jun 15, 2023
Merged
FabijanC
FabijanC requested changes Jun 20, 2023
View reviewed changes
www/docs/dev.md Outdated Show resolved Hide resolved
@FabijanC FabijanC self-requested a review June 20, 2023 14:34
@FabijanC FabijanC merged commit f62049b into 0xSpaceShard:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test cairo1 events
3 participants
@notV4l @Nathan-SL @FabijanC