Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prebuilt binaries on Cairo installation #399

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Use prebuilt binaries on Cairo installation #399

merged 8 commits into from
Jul 14, 2023

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Jul 11, 2023 •
edited
Loading

Usage related changes

Development related changes

  • Change Cairo source installation to using prebuilt binaries
  • Avail binaries for all test groups

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL requested a review from FabijanC July 11, 2023 12:23
FabijanC
FabijanC requested changes Jul 12, 2023
View reviewed changes
test/general-tests/declare-v2-test/hardhat.config.ts Outdated Show resolved Hide resolved
scripts/setup-config-test-dependencies.sh Outdated Show resolved Hide resolved
scripts/setup-config-test-dependencies.sh Show resolved Hide resolved
@Nathan-SL Nathan-SL merged commit 6ee7ea7 into master Jul 14, 2023
@Nathan-SL Nathan-SL deleted the prebuilt-binary branch July 14, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace cairo installation from source with prebuilt binaries
2 participants
@Nathan-SL @FabijanC