Specify testing network with a network.json file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR merge to master resulted in a failing CircleCI test workflow. This is due to an error-prone way of specifying on which network a test should be executed.
This PR improves the if-else construct that was so far used in test.sh. Instead of specifying the tests to be skipped in test.sh, a network-specifying file (network.json) is placed inside the test directory. The file should indicate which networks should be targeted. If there is no file, the current network gets tested. Expected format:
{ "devnet": true }Usage changes
Dev specific changes
The tests are failing on the last commit because I cancelled them as they only introduce new comments or update documentation.