Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix starknet-network specifying with hh run #74

Merged
merged 7 commits into from
Mar 9, 2022
Merged

Fix starknet-network specifying with hh run #74

merged 7 commits into from
Mar 9, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Mar 9, 2022 •
edited
Loading

Usage

  • Remove --starknet-network from hardhat run options:
    • strictly speaking a breaking change
    • not so breaking because it never could have been used
    • fix network specifying through hardhat.config

Dev specific changes

None

@FabijanC FabijanC requested review from dribeiro-ShardLabs and removed request for dribeiro-ShardLabs March 9, 2022 08:21
@FabijanC FabijanC merged commit 718e7a4 into master Mar 9, 2022
@FabijanC FabijanC deleted the fix-run-network branch March 9, 2022 10:50
This was referenced Oct 19, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dribeiro-ShardLabs dribeiro-ShardLabs dribeiro-ShardLabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @dribeiro-ShardLabs