Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getTransaction and getTransaction receipt functions #81

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

dribeiro-ShardLabs
Copy link
Contributor

@dribeiro-ShardLabs dribeiro-ShardLabs commented Mar 16, 2022

Usage related changes

  • Implement getTransaction and getTransactionReceipt functions for the starknet object

Development related changes

  • GetTxStatusWrapperOptions type was changed to a more generic TxHashQueryWrapperOptions, because there are now multiple functions that use the same structure for transaction hash based queries:
    -- prepareGetTxStatusOptions was changed to prepareGetTxQueryOptions, and now takes an additional argument command as a parameter;
  • L1Message and L2Message types were changed to L1ToL2Message and L2ToL1Message respectively to be more clear;

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

@dribeiro-ShardLabs dribeiro-ShardLabs merged commit 6c9a05e into master Mar 17, 2022
@dribeiro-ShardLabs dribeiro-ShardLabs deleted the get-tx-receipt branch March 17, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants