Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Block Utility Function #97

Merged
merged 7 commits into from
May 3, 2022
Merged

Get Block Utility Function #97

merged 7 commits into from
May 3, 2022

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Apr 22, 2022 •
edited
Loading

Usage related changes

  • Implement getBlock utility function for the starknet object
    • Accepts optional identifier object containing optional properties blockHash and blockNumber
  • Update the error message to be more descriptive when missing contracts during a test in the example repo.

Development related changes

  • None

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

@Nathan-SL
Add Get block utility function
53f6674
@Nathan-SL
Get block data by hash and block_number
3be9bfc 
- Both params can be optional
@Nathan-SL
Use descriptive error message
4f8885f 
- Change contractPath to metadataSearchTarget in plugin error
@Nathan-SL
Change based on lint
fcbf999 
- Remove trailing comma
- Change Object[] to Record<string, unknown>
@Nathan-SL Nathan-SL requested a review from FabijanC April 22, 2022 15:37
@Nathan-SL Nathan-SL mentioned this pull request Apr 22, 2022
Merged
FabijanC
FabijanC requested changes May 2, 2022
View reviewed changes
src/extend-utils.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/starknet-wrappers.ts Outdated Show resolved Hide resolved
FabijanC
FabijanC requested changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update the PR description to reflect the new changes.

src/type-extensions.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC self-requested a review May 3, 2022 09:43
@FabijanC FabijanC merged commit 443458f into master May 3, 2022
@FabijanC FabijanC deleted the feature/get-block branch May 3, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nathan-SL @FabijanC