Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Voyager verification #98

Merged
merged 4 commits into from
May 4, 2022
Merged

Adapt Voyager verification #98

merged 4 commits into from
May 4, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented May 3, 2022 •
edited
Loading

Usage related changes

  • Adapt starknet-verify to the new Voyager API.
  • Since Voyager almost always returns 502 Bad Gateway, it was hard to do some meaningful error interpretation. That's why in case of an unsuccessful verification the most likely reasons are listed.

Development related changes

  • Modify and uncomment verification testing.

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I didn't have to create a PR to the plugin branch of starknet-hardhat-example.

@FabijanC FabijanC requested a review from badurinantun May 3, 2022 08:13
@FabijanC FabijanC changed the title Adapt voyager Adapt Voyager verification May 3, 2022
@FabijanC FabijanC merged commit 9dd19d1 into master May 4, 2022
@FabijanC FabijanC deleted the adapt-voyager branch May 4, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badurinantun badurinantun badurinantun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @badurinantun