Prevent a fatal error when API request fails

[dkotter]

Description of the Change

We had an issue where API credentials were revoked and it caused a fatal error on our site. This error originated in the code that gets a list of all available players. The request to get the players will fail and we have a is_wp_error check on that but we don't check for that until after we try and use the returned value (which causes fatals if that value is an error).

This PR moves that check up prior to us trying to use that value and also adds a check to ensure the returned value isn't false.

Alternate Designs

None

Benefits

Prevent fatal errors if API credentials are revoked.

Possible Drawbacks

None

Verification Process

This fix was pushed into our staging environment that was experiencing the fatal errors and this resolved those

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

[oscarssanchez]

Hi @dkotter, I will bring this one on our Monthly meeting with Brightcove