Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add State, Scheduled Start Date and Scheduled End Date fields #241

Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Nov 24, 2021

Description of the Change

This PR adds three new fields to the video edit screen.That way, the user can change the state and availability of videos.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Added State, Scheduled Start Date, and Scheduled End Date fields to the video edit screen.

oscarssanchez and others added 28 commits January 2, 2020 14:04
Merge develop into Master for 1.9.2 wp.org release.
Update stable tag to 2.3.0
@Rahmon Rahmon added this to the 2.5.0 milestone Nov 24, 2021
@oscarssanchez
Copy link
Contributor

Hi @Rahmon ,

I've noticed that you can set scheduled times that don't make sense. For example, I was able to schedule this time:

Screen Shot 2021-11-26 at 13 14 20

I don't think the plugin should let you do that, perhaps have some sort of validation before submitting the changes?

I'm thinking the following scenarios:

  • You should not be able to pick an end date from the past
  • The start date should always be before the end date.

@oscarssanchez
Copy link
Contributor

@Rahmon

Should the video become unavailable if the end date has been passed already?

From our test account, I have set the Video ID 6075916217001 end date to November 20, however the video is still available.

@oscarssanchez
Copy link
Contributor

Also, it seems like if you have set dates already and you remove those, the dates will remain set to "now". Is it the expected behavior?

@Rahmon Rahmon merged commit dd13ccd into develop Dec 14, 2021
@Rahmon Rahmon deleted the feature/activating-deactivating-scheduling-videos-sit-2553 branch December 14, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants