Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/broken bc experiences #248

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Fix/broken bc experiences #248

merged 4 commits into from
Jan 17, 2022

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

This PR brings back code that the Video and Playlist experience embedding depends on. It looks like this code is ok to keep and should not interfere with in page experiences at all.

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@oscarssanchez oscarssanchez merged commit 0d66153 into develop Jan 17, 2022
@oscarssanchez oscarssanchez deleted the fix/broken-bc-experiences branch January 17, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants